Yida Wu has uploaded this change for review. (
http://gerrit.cloudera.org:8080/25052
Change subject: IMPALA-15408: Don't ignore custom executor groups with default
group
......................................................................
IMPALA-15408: Don't ignore custom executor groups with default group
In clusters containing both custom executor groups and unassigned
(default) nodes, queries targeting custom pools can incorrectly
route to default nodes because PopulateExecutorMembershipRequest()
short-circuits on the first default node, hiding all custom
executor groups.
This patch fixes this by dropping the early return, ensuring both
default and custom groups are appended.
The frontend is also updated to explicitly handle the default
group's empty name prefix:
- Unspecified pools: retained as an unrestricted candidate for
queries with no request pool, bypassing the cluster-wide limits
that getPoolConfig("") falls back to.
- Specified pools: skipped during matching so unknown pools
are properly rejected rather than falling back to default
executors.
- Pool assignment: for the default group, the frontend now leaves
the pool name completely unset.
Clusters with only default or only custom groups are unaffected.
Testing:
Passed core tests and manually verified mixed-cluster routing.
Added mixed-cluster test case to ClusterMembershipMgrUnitTest.
Added ExecutorGroupSetSelectionTest to verify frontend pool
stamping and preserve default-only/custom-only behaviors.
Change-Id: I3ca59dff1d1e305985f98e640f64c483920e8178
Assisted-by: Claude Opus 5.5 (Claude Code)
---
M be/src/scheduling/cluster-membership-mgr-test.cc
M be/src/scheduling/cluster-membership-mgr.cc
M common/thrift/Frontend.thrift
M fe/src/main/java/org/apache/impala/service/Frontend.java
A fe/src/test/java/org/apache/impala/service/ExecutorGroupSetSelectionTest.java
5 files changed, 303 insertions(+), 24 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/25052/1
--
To view, visit http://gerrit.cloudera.org:8080/25052
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3ca59dff1d1e305985f98e640f64c483920e8178
Gerrit-Change-Number: 25052
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <[email protected]>
