Laszlo Gaal (Cloudera) has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/25023 )

Change subject: Run Kudu 1.18.1 container
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/25023/2/testdata/cluster/node_templates/common/etc/init.d/kudu-common
File testdata/cluster/node_templates/common/etc/init.d/kudu-common:

http://gerrit.cloudera.org:8080/#/c/25023/2/testdata/cluster/node_templates/common/etc/init.d/kudu-common@51
PS2, Line 51: docker run
Conditional suggestion (because I'm not sure Kudu actually needs it):
if Kudu can spawn child processes, consider adding the '--init' flag to insert 
a proper init-like process for PID 1 (zombie reaping, signal forwarding).
See https://docs.docker.com/reference/cli/docker/container/run/#init for 
details; disregard if not needed :)


http://gerrit.cloudera.org:8080/#/c/25023/2/testdata/cluster/node_templates/common/etc/init.d/kudu-common@53
PS2, Line 53: \
maybe add the timezone/localtime files, or the TZ env var to sync the 
container's timezone to the local host for better log sync?
Not a strong ask though; upstream precommit works in UTC, so this will work 
there.



--
To view, visit http://gerrit.cloudera.org:8080/25023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88d638492b5e664d8630fc9453094ef6bc24683c
Gerrit-Change-Number: 25023
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Comment-Date: Wed, 07 Oct 2026 22:12:12 +0000
Gerrit-HasComments: Yes

Reply via email to