Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24977
to look at the new patch set (#2).
Change subject: IMPALA-15447: synthesize Iceberg scan reports on the fast path
......................................................................
IMPALA-15447: synthesize Iceberg scan reports on the fast path
When Impala's fast path skips Iceberg planFiles(), no ScanReport is
produced, so a deployment forwarding scan reports (previous change)
sees nothing for those queries. Synthesize a report from the file
descriptors and conjuncts already computed and hand it only to the
configured side reporter; the InMemory reporter and query profile are
left untouched.
The synthesized report is marked synthesized=true so consumers can
distinguish it from one Iceberg produced. It carries distinct
delete-file counters (positional, equality, DVs) rather than a lumped
total, uses the scanned snapshot's schema id (not the table's current
schema, which differs for time-travel queries), and runs the filter
through ExpressionUtil.sanitize() so literals are redacted, matching
what Iceberg does for real reports.
Each scan report also carries an unpushed-predicates metadata entry: a
JSON list of {col, op} for the conjuncts the scan applies that are not
in the reported filter (not convertible to an Iceberg Expression, or
push-down never attempted on the fast path). Only the column and a
coarse operator category (equality, not-equality, range, in, not-in,
other) are emitted; no literals.
Testing:
- Added IcebergFastPathReportTest: asserts the fast path emits a
report tagged synthesized=true, a non-Iceberg scan emits none, and
unpushed predicates are reported with the expected operator
category on both the fast path and the push-down path (run: mvn test
-Dtest=IcebergFastPathReportTest). The test sets
metrics-reporter-impl and resets the memoized side reporter, so run
it in its own fork.
- Ran gerrit-auto-critic (--dryrun): clean.
Change-Id: I9c32206da225e127da37506c820cc35ad8a0e1ab
Assisted-by: Claude Opus 4.8 (Claude Code)
Co-Authored-By: Claude Opus 4.8 <[email protected]>
---
M fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java
A fe/src/test/java/org/apache/impala/planner/IcebergFastPathReportTest.java
2 files changed, 428 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/24977/2
--
To view, visit http://gerrit.cloudera.org:8080/24977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9c32206da225e127da37506c820cc35ad8a0e1ab
Gerrit-Change-Number: 24977
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
