Daniel Vanko has posted comments on this change. ( http://gerrit.cloudera.org:8080/24636 )
Change subject: IMPALA-8523: Migrate hdfsOpen to builder-based openFile API ...................................................................... Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/24636/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24636/8//COMMIT_MSG@36 PS8, Line 36: nbuffers the file handle after every read, so the GET-to-EOF : that 'se > Hadoop 3.4.2 already recognizes the parquet/orc/avro/json policy names Done http://gerrit.cloudera.org:8080/#/c/24636/8//COMMIT_MSG@58 PS8, Line 58: 2 > performance hint? Done http://gerrit.cloudera.org:8080/#/c/24636/8/be/src/util/open-file-options-util.cc File be/src/util/open-file-options-util.cc: http://gerrit.cloudera.org:8080/#/c/24636/8/be/src/util/open-file-options-util.cc@44 PS8, Line 44: // hard-aborts the connection when more than fs.s3a.readahead.range (64KB by default) is : // left over, so each read pays a fresh connection. 'adaptive' self-corrects to random : // after the first abort; 'sequential' never does. : // That makes 'sequential' the worst of the three here, and bounded reads under 'random' : // avoid the aborts entirely. > Opus 5.5 said the following, please validate: Yeah, that's right. Rewrote the open-file-options-util to use 'random' for every format and added justification along with text and Avro measurements to the commit message. -- To view, visit http://gerrit.cloudera.org:8080/24636 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46d810b19fe7d4859e3c2bcd7568b61fe73408c1 Gerrit-Change-Number: 24636 Gerrit-PatchSet: 9 Gerrit-Owner: Daniel Vanko <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 08 Oct 2026 12:09:12 +0000 Gerrit-HasComments: Yes
