Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10951 )
Change subject: IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved. ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10951/1/be/src/exec/hdfs-parquet-table-writer.cc File be/src/exec/hdfs-parquet-table-writer.cc: http://gerrit.cloudera.org:8080/#/c/10951/1/be/src/exec/hdfs-parquet-table-writer.cc@343 PS1, Line 343: if (std::is_floating_point<T>::value) valid_column_index_ = false; Will this still allow page skipping for predicates on other columns? -- To view, visit http://gerrit.cloudera.org:8080/10951 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50aa2e6607de6a8943eb068b8162b0506763078b Gerrit-Change-Number: 10951 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 16 Jul 2018 20:12:39 +0000 Gerrit-HasComments: Yes
