Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10791 )
Change subject: IMPALA-7199: Add scripts to create code coverage reports ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/10791/2/bin/coverage_helper.sh File bin/coverage_helper.sh: http://gerrit.cloudera.org:8080/#/c/10791/2/bin/coverage_helper.sh@44 PS2, Line 44: shift; > is that semicolon doing anything? Removed (I copy/pasted from buildall.sh) http://gerrit.cloudera.org:8080/#/c/10791/2/bin/coverage_helper.sh@51 PS2, Line 51: shift; > I don't think that semicolon needs to be tehre? Removed -- To view, visit http://gerrit.cloudera.org:8080/10791 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b2e0b794c64f9343ec976de7a3f235e54d2badd Gerrit-Change-Number: 10791 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Comment-Date: Mon, 16 Jul 2018 21:51:40 +0000 Gerrit-HasComments: Yes
