Jim Apple has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10615 )
Change subject: IMPALA-7132: Filter out useless output from run_clang_tidy.sh ...................................................................... IMPALA-7132: Filter out useless output from run_clang_tidy.sh Clang's run-clang-tidy.py script produces a lot of output even when there are no warnings or errors. None of this output is useful. This patch has two parts: 1. Bump LLVM to 5.0.1-p1, which has patched run-clang-tidy.py to make it reduce its own output when passed -quiet (along with other enhancements). 2. Pass -quiet to run-clang-tidy.py and pipe the stderr output to a temporary file. Display this output only if run-clang-tidy.py hits an error, as this output is not useful otherwise. Testing with a known clang tidy issue shows that warnings and errors are still in the output, and the output is clean on a clean Impala checkout. Change-Id: I63c46a7d57295eba38fac8ab49c7a15d2802df1d Reviewed-on: http://gerrit.cloudera.org:8080/10615 Reviewed-by: Jim Apple <jbapple-imp...@apache.org> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M bin/bootstrap_toolchain.py M bin/impala-config.sh M bin/run_clang_tidy.sh 3 files changed, 14 insertions(+), 6 deletions(-) Approvals: Jim Apple: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I63c46a7d57295eba38fac8ab49c7a15d2802df1d Gerrit-Change-Number: 10615 Gerrit-PatchSet: 5 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>