Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10973 )
Change subject: IMPALA-7140 (part 9): add support for SHOW FILES in LocalFsTable ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10973/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/10973/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@2111 PS1, Line 2111: new ArrayList<> > nit: existing code uses the google lists pkg. any reason not to use it in t no particular reason, figured that since Java 7 it's easier to just use the <> trick unless using one of the fancier methods like newArrayListWithCapacity(). I'll change. -- To view, visit http://gerrit.cloudera.org:8080/10973 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I143bea9f72b6a25ae2545663e06f4849b58533ba Gerrit-Change-Number: 10973 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Thu, 19 Jul 2018 00:09:42 +0000 Gerrit-HasComments: Yes
