Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10913 )

Change subject: IMPALA-7276. Support CREATE TABLE AS SELECT with LocalCatalog
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10913/3/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java
File fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java:

http://gerrit.cloudera.org:8080/#/c/10913/3/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java@114
PS3, Line 114: load them?
> makes sense... I'd prefer the flag to guard.
nope, this would only show up temporarily in the analyzer during analysis of a 
CREATE TABLE AS SELECT statement -- it never gets inserted into any Db and 
never sticks around outside the scope of a single CTAS



--
To view, visit http://gerrit.cloudera.org:8080/10913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93937aed9b76ef6a62b1c588c59c34d3d6831a46
Gerrit-Change-Number: 10913
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Jul 2018 00:21:01 +0000
Gerrit-HasComments: Yes

Reply via email to