Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10980 )
Change subject: IMPALA-7298: Stop passing IP address as hostname in Kerberos principal ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10980/1/be/src/runtime/krpc-data-stream-sender.cc File be/src/runtime/krpc-data-stream-sender.cc: http://gerrit.cloudera.org:8080/#/c/10980/1/be/src/runtime/krpc-data-stream-sender.cc@598 PS1, Line 598: destinations[i].thrift_backend.hostname, > Instead of adding this new parameter, would it be possible to ensure that " destinations[i].krpc_backend.hostname is actually set to the resolved IP address of hostname so we have to pull it from thrift_backend.hosname. As we remove Thrift from communications between Impala backends in the future, we need to move thrift_backend.hostname into a separate field in TPlanFragmentDestination. -- To view, visit http://gerrit.cloudera.org:8080/10980 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e3e978746cf03766eee151835aad5877d9ed63e Gerrit-Change-Number: 10980 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Thu, 19 Jul 2018 00:47:50 +0000 Gerrit-HasComments: Yes
