Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/10587 )
Change subject: IMPALA-6994: Avoid reloading a table's HMS data for file-only operations ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/10587/3/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/10587/3/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1251 PS3, Line 1251: RELOAD_PARTITION_METADATA if not set in flags results in not getting the : * partition details from HiveMetaStore in updatePartitionsFromHms(). > nit: this double negative is a bit confusing. Perhaps it's clearer to rephr Changed the comment, thanks for rewording it. http://gerrit.cloudera.org:8080/#/c/10587/3/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1254 PS3, Line 1254: or if there are no partitions in the table > I'm not sure I follow this part. How does the caller know if there are no p That's right the unpartitioned case doesn't have to consider this, I have removed the sentence. -- To view, visit http://gerrit.cloudera.org:8080/10587 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I331bb0371fde287f43a85b025b4f98cb45f3eb3c Gerrit-Change-Number: 10587 Gerrit-PatchSet: 3 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Balazs Jeszenszky <jes...@gmail.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Fri, 20 Jul 2018 18:57:05 +0000 Gerrit-HasComments: Yes
