Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/10908 )
Change subject: IMPALA-7209: Disallow self referencing in ALTER VIEW statements ...................................................................... Patch Set 8: (7 comments) http://gerrit.cloudera.org:8080/#/c/10908/7/fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java: http://gerrit.cloudera.org:8080/#/c/10908/7/fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java@21 PS7, Line 21: import java.util.Set; > Remove Done http://gerrit.cloudera.org:8080/#/c/10908/7/fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java@24 PS7, Line 24: import org.apache.impala.catalog.FeTable; > Remove Done http://gerrit.cloudera.org:8080/#/c/10908/7/fe/src/main/java/org/apache/impala/analysis/QueryStmt.java File fe/src/main/java/org/apache/impala/analysis/QueryStmt.java: http://gerrit.cloudera.org:8080/#/c/10908/7/fe/src/main/java/org/apache/impala/analysis/QueryStmt.java@138 PS7, Line 138: FeView > Just curious, why can't we collect Set<InlineViewRef> directly? I had no semantic reason, I was only trying to follow the convention of collectTableRefs. In that function the TableRefs are collected in SQL clause order. http://gerrit.cloudera.org:8080/#/c/10908/7/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/10908/7/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@147 PS7, Line 147: // Returns the QueryStmt present in the whereClause_ if present, null otherwise. > ...Null otherwise... Done http://gerrit.cloudera.org:8080/#/c/10908/7/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@148 PS7, Line 148: getWhereQueryStm > I think getWhereSubQueryStmt() makes more sense. Also make it private? I have changed it to private. I initially named it getWhereSubQueryStmt but then noticed that there is another class called SubQuery. So I thought it might be misleading. Do you think it would be okay to change it? http://gerrit.cloudera.org:8080/#/c/10908/7/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@1076 PS7, Line 1076: public void collectInlineViewRefs(Set<FeView> inlineViewRefs) { > nit: Mention that currently only from/where subqueries are supported. Other Done http://gerrit.cloudera.org:8080/#/c/10908/7/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@1077 PS7, Line 1077: // Impala currently supports sub queries only in FROM & WHERE clauses. Hence, this > Preconditions.checkNotNull(inlineViewRefs); Done -- To view, visit http://gerrit.cloudera.org:8080/10908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17c231c9d74d9d411463a408b086eb874090b9b7 Gerrit-Change-Number: 10908 Gerrit-PatchSet: 8 Gerrit-Owner: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Comment-Date: Mon, 23 Jul 2018 18:07:40 +0000 Gerrit-HasComments: Yes
