Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11022 )
Change subject: IMPALA-7291: [DOCS] Note about no codegen support for CHAR ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11022/1/docs/topics/impala_char.xml File docs/topics/impala_char.xml: http://gerrit.cloudera.org:8080/#/c/11022/1/docs/topics/impala_char.xml@93 PS1, Line 93: Therefore, <codeph>LENGTH()</codeph> represents the : length including any trailing spaces, I think this is backwards - LENGTH() strips off trailing spaces. CHAR_LENGTH() is the alternative version that doesn't: [localhost:21000] default> select length(cast('test' as char(10))); Query: select length(cast('test' as char(10))) Query submitted at: 2018-07-23 16:19:11 (Coordinator: http://tarmstrong-box:25000) Query progress can be monitored at: http://tarmstrong-box:25000/query_plan?query_id=643b0d940529bcf:2872caec00000000 +----------------------------------+ | length(cast('test' as char(10))) | +----------------------------------+ | 4 | +----------------------------------+ Fetched 1 row(s) in 0.12s [localhost:21000] default> select char_length(cast('test' as char(10))); Query: select char_length(cast('test' as char(10))) Query submitted at: 2018-07-23 16:19:36 (Coordinator: http://tarmstrong-box:25000) Query progress can be monitored at: http://tarmstrong-box:25000/query_plan?query_id=a046dffe3b57352f:4acea77600000000 +---------------------------------------+ | char_length(cast('test' as char(10))) | +---------------------------------------+ | 10 | +---------------------------------------+ Fetched 1 row(s) in 0.11s http://gerrit.cloudera.org:8080/#/c/11022/1/docs/topics/impala_char.xml@99 PS1, Line 99: Retruns typo: Returns -- To view, visit http://gerrit.cloudera.org:8080/11022 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id89dcf44e31f1bc56d888527585b3ec90229981a Gerrit-Change-Number: 11022 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Balazs Jeszenszky <jes...@gmail.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 23 Jul 2018 23:21:36 +0000 Gerrit-HasComments: Yes
