Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11026 )
Change subject: IMPALA-7340. Only send necessary fields in THdfsPartition ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11026/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/11026/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1722 PS1, Line 1722: * included. Otherwise, don't include any THdfsFileDescs, and include only those partitions > What's the guidance here? The Google guide says 100 chars for Java: https:/ Yea, we usually stick to 90 chars. -- To view, visit http://gerrit.cloudera.org:8080/11026 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97e8402efdfdeea06463bb71a40ebb6abd1f11f0 Gerrit-Change-Number: 11026 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Tue, 24 Jul 2018 16:38:29 +0000 Gerrit-HasComments: Yes
