Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10771 )
Change subject: PREVIEW: IMPALA-110: Support for multiple DISTINCT ...................................................................... Patch Set 1: (2 comments) Did another pass over the backend. No major concerns, I assume that the non-preview will have some more method comments etc. http://gerrit.cloudera.org:8080/#/c/10771/1/be/src/exec/aggregator.h File be/src/exec/aggregator.h: http://gerrit.cloudera.org:8080/#/c/10771/1/be/src/exec/aggregator.h@77 PS1, Line 77: RowBatch* child_batch, bool* eos) = 0; 'eos' signals that out_batch is the last batch to be returned? Does this avoid a call to GetNext() or something? Oh ok, I looked at the code some more - this is really signaling that it have more rows produced from 'child_batch' to append to 'out_batch', right? http://gerrit.cloudera.org:8080/#/c/10771/1/be/src/exprs/aggregate-functions-ir.cc File be/src/exprs/aggregate-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/10771/1/be/src/exprs/aggregate-functions-ir.cc@1694 PS1, Line 1694: void AggregateFunctions::AggIfUpdate( I'm not suggesting that we do this, but it would be cool if we added FILTER support and used that mechanism: https://modern-sql.com/feature/filter -- To view, visit http://gerrit.cloudera.org:8080/10771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I055402eaef6d81e5f70e850d9f8a621e766830a4 Gerrit-Change-Number: 10771 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 25 Jul 2018 22:32:56 +0000 Gerrit-HasComments: Yes
