Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11052 )
Change subject: IMPALA-6644: Add recent heartbeat timestamp into Statestore metric ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/11052/1/be/src/statestore/statestore.h File be/src/statestore/statestore.h: http://gerrit.cloudera.org:8080/#/c/11052/1/be/src/statestore/statestore.h@417 PS1, Line 417: Sets > nit: typo Done http://gerrit.cloudera.org:8080/#/c/11052/1/be/src/statestore/statestore.h@442 PS1, Line 442: This timestamp is updated : /// every "statestore_heartbeat_log_frequency_seconds" seco > needs more explanation. how about instead: Done http://gerrit.cloudera.org:8080/#/c/11052/1/be/src/statestore/statestore.cc File be/src/statestore/statestore.cc: http://gerrit.cloudera.org:8080/#/c/11052/1/be/src/statestore/statestore.cc@390 PS1, Line 390: _h > FLAGS_statestore_heartbeat_log_frequency_seconds I have removed this comment and instead modified the DCHECK. http://gerrit.cloudera.org:8080/#/c/11052/1/be/src/statestore/statestore.cc@389 PS1, Line 389: DCHECK(timestamp_seconds : > (recent_heartbeat_timestamp_ + FLAGS_statestore_heartbeat_log_frequency_seconds)); : recent_heartbeat_timestamp_ = timestamp_seconds; > maybe instead of the comment, a dcheck for the following should be self exp Done -- To view, visit http://gerrit.cloudera.org:8080/11052 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I754adccc4569e8219d5d01500cccdfc8782953f7 Gerrit-Change-Number: 11052 Gerrit-PatchSet: 2 Gerrit-Owner: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Comment-Date: Fri, 27 Jul 2018 19:18:50 +0000 Gerrit-HasComments: Yes
