Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11064 )
Change subject: IMPALA-7362: Add query option to set timezone ...................................................................... Patch Set 3: Code-Review+1 (2 comments) Will let Attila take a look too http://gerrit.cloudera.org:8080/#/c/11064/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11064/2//COMMIT_MSG@9 PS2, Line 9: This change adds a new query option "timezone" which > I am unsure about this - Linux uses /etc/timezone and $TZ for the same conc Yeah I kind of like the shorter name "timezone" upon further reflection. http://gerrit.cloudera.org:8080/#/c/11064/2/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/11064/2/tests/shell/test_shell_commandline.py@706 PS2, Line 706: assert actual_time_s <= time_limit_s, ( Can you also add a test to tests/metadata/test_set.py that exercises the server-side 'set' command? -- To view, visit http://gerrit.cloudera.org:8080/11064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73de86eff096e1c581d3b56a0d9330d686f77272 Gerrit-Change-Number: 11064 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 27 Jul 2018 22:11:08 +0000 Gerrit-HasComments: Yes
