Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10970 )
Change subject: IMPALA-7308. Support Avro tables in LocalCatalog ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/10970/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10970/5//COMMIT_MSG@39 PS5, Line 39: if an Avro partition is added to a non-Avro table, and that partition : has a schema that isn't compatible with the table's schema, an error : will occur on read. Can we test this yet? Or is the plan to test existing and local catalog together after IMPALA-7309? http://gerrit.cloudera.org:8080/#/c/10970/5/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/10970/5/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1558 PS5, Line 1558: ; Why don't we return here? Is there any need to reconcile a inferred schema? http://gerrit.cloudera.org:8080/#/c/10970/5/fe/src/main/java/org/apache/impala/util/AvroSchemaUtils.java File fe/src/main/java/org/apache/impala/util/AvroSchemaUtils.java: http://gerrit.cloudera.org:8080/#/c/10970/5/fe/src/main/java/org/apache/impala/util/AvroSchemaUtils.java@47 PS5, Line 47: HdfsTable AvroSchemaUtils http://gerrit.cloudera.org:8080/#/c/10970/5/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java File fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java: http://gerrit.cloudera.org:8080/#/c/10970/5/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@239 PS5, Line 239: // TODO(todd): do we have any tables which are mixed format? alltypesmixedformat: https://github.com/apache/impala/blob/b5608264b4552e44eb73ded1e232a8775c3dba6b/testdata/bin/load-dependent-tables.sql#L62 -- To view, visit http://gerrit.cloudera.org:8080/10970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4b86c8203271b773a711ed77558ec3e3070cb69 Gerrit-Change-Number: 10970 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Fri, 27 Jul 2018 23:30:32 +0000 Gerrit-HasComments: Yes
