Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11054 )

Change subject: IMPALA-7317: add scripts to post flake8 comments
......................................................................


Patch Set 15:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/11054/15/bin/jenkins/critique-gerrit-review.py
File bin/jenkins/critique-gerrit-review.py:

http://gerrit.cloudera.org:8080/#/c/11054/15/bin/jenkins/critique-gerrit-review.py@50
PS15, Line 50: import time
flake8: F401 'time' imported but unused


http://gerrit.cloudera.org:8080/#/c/11054/15/bin/jenkins/critique-gerrit-review.py@108
PS15, Line 108: "
flake8: E128 continuation line under-indented for visual indent


http://gerrit.cloudera.org:8080/#/c/11054/15/bin/jenkins/critique-gerrit-review.py@127
PS15, Line 127: if __name__ == "__main__":
flake8: E305 expected 2 blank lines after class or function definition, found 1



--
To view, visit http://gerrit.cloudera.org:8080/11054
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d348ea4944f829a407bd7b2939654f272736170
Gerrit-Change-Number: 11054
Gerrit-PatchSet: 15
Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: David Knupp <dkn...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Jul 2018 22:51:20 +0000
Gerrit-HasComments: Yes

Reply via email to