Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 )
Change subject: IMPALA-376: add built-in functions for parsing JSON ...................................................................... Patch Set 9: (2 comments) Thanks for your cool idea! Just be able to come back to this work. Will update this patch soon. http://gerrit.cloudera.org:8080/#/c/10950/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10950/9//COMMIT_MSG@11 PS9, Line 11: old RapidJson version, we cannot get detailed errors if parse fails. > Should we consider upgrading rapidjson? It might need some efforts as Matthew mentioned in the commend of IMPALA-2014: https://issues.apache.org/jira/browse/IMPALA-2014?focusedCommentId=15913404&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-15913404 Anyway, I create a JIRA for this: IMPALA-7364 http://gerrit.cloudera.org:8080/#/c/10950/9/be/src/exprs/string-functions.cc File be/src/exprs/string-functions.cc: http://gerrit.cloudera.org:8080/#/c/10950/9/be/src/exprs/string-functions.cc@51 PS9, Line 51: return ctx_->Allocate(size); > Yeah exactly, the memory is recycled in bulk by Impala's runtime at some po Cool! That's a better fit. -- To view, visit http://gerrit.cloudera.org:8080/10950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a9d3598cb3beca0865a7edb094f3a5b602dbd2f Gerrit-Change-Number: 10950 Gerrit-PatchSet: 9 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 31 Jul 2018 11:21:07 +0000 Gerrit-HasComments: Yes
