Le Minh Nghia has posted comments on this change. ( http://gerrit.cloudera.org:8080/10900 )
Change subject: IMPALA-1624: Allow toggling and unsetting some command-line options inside impala-shell ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/10900/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10900/6//COMMIT_MSG@15 PS6, Line 15: Added tests for all new options in test_shell_interactive.py > Did you test this change on Python 2.6 as well? If yes, can you update the Done http://gerrit.cloudera.org:8080/#/c/10900/5/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/10900/5/tests/shell/test_shell_interactive.py@91 PS5, Line 91: """Test output rows in delimited mode""" > nit: please add some doc comments to the tests. Done http://gerrit.cloudera.org:8080/#/c/10900/6/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/10900/6/tests/shell/test_shell_interactive.py@122 PS6, Line 122: "r" > nit: use "r" to be consistent with the code in this function. Done -- To view, visit http://gerrit.cloudera.org:8080/10900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8d4487c24f24806223bfd5c54336914e3afd763 Gerrit-Change-Number: 10900 Gerrit-PatchSet: 7 Gerrit-Owner: Le Minh Nghia <le.ng...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jinchul Kim <jinc...@gmail.com> Gerrit-Reviewer: Le Minh Nghia <le.ng...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 31 Jul 2018 13:58:09 +0000 Gerrit-HasComments: Yes
