Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10966 )
Change subject: IMPALA-7217: Incorrect UPDATE/DELETE authorization privilege ...................................................................... Patch Set 4: > Patch Set 4: > > (4 comments) > > My comments are mainly related to the DELETE t1 FROM t1, t2 WHERE ... case. > t1 should need ALL privileges in this case and must be a Kudu table, while t2 > should only need SELECT on the referred columns and can be any kind of table. Thanks for the review! Your comment makes sense. I agree that only the target table needs to have ALL privilege and not other tables in the from clause. This problem will be more apparent once we have a DELETE privilege since the existing code will require both DELETE and SELECT privileges on the target table because the existing code always requires SELECT on all tables in the from clause. I'll need to spend more time on this. -- To view, visit http://gerrit.cloudera.org:8080/10966 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I69d451f727a7df6c41166a15cf1ed6f5334dc739 Gerrit-Change-Number: 10966 Gerrit-PatchSet: 4 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Adam Holley <ahol...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Tue, 31 Jul 2018 18:34:04 +0000 Gerrit-HasComments: No
