Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11074 )
Change subject: IMPALA-3330: [DOCS] TRANSLATE function updated ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11074/2/docs/topics/impala_string_functions.xml File docs/topics/impala_string_functions.xml: http://gerrit.cloudera.org:8080/#/c/11074/2/docs/topics/impala_string_functions.xml@1294 PS2, Line 1294: beyond the length of <codeph>to</codeph> are replaced with : <codeph>NULL</codeph> This is still incorrect. They are not replaced with NULL, they are removed from input. http://gerrit.cloudera.org:8080/#/c/11074/2/docs/topics/impala_string_functions.xml@1323 PS2, Line 1323: example: <codeph>translate ('hello','ll','12')</codeph> returns Maybe chose characters that don't look as alike as 'l' and '1'? -- To view, visit http://gerrit.cloudera.org:8080/11074 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica33ecbb7118e3034f95c5705eed19d169dc16cb Gerrit-Change-Number: 11074 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Comment-Date: Tue, 31 Jul 2018 22:38:13 +0000 Gerrit-HasComments: Yes
