Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11000 )
Change subject: IMPALA-5542: Impala cannot scan Parquet decimal stored as int64_t/int32_t ...................................................................... Patch Set 4: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/11000/2/be/src/exec/parquet-metadata-utils.cc File be/src/exec/parquet-metadata-utils.cc: http://gerrit.cloudera.org:8080/#/c/11000/2/be/src/exec/parquet-metadata-utils.cc@203 PS2, Line 203: == parquet::Type::INT64 && > Based on https://github.com/apache/parquet-format/blob/518e206c3e6586b76e83 I see. Thanks for the explanation. http://gerrit.cloudera.org:8080/#/c/11000/2/be/src/exec/parquet-metadata-utils.cc@234 PS2, Line 234: : // The other decimal metadata should be there but we don't need it. : if (!schema_element.__isset.precision) { : ErrorMsg msg(TErrorCode::PARQUET_MISSING_PRECISION, filename, schema_element.name); : RETURN_IF_ERROR(state->LogOrReturnError(msg)); : } else { : if (schema_element.precision != slot_desc->type().precision) { : // TODO: we could allow a mismatch and do a conversion at this step. : ErrorMsg msg(TErrorCode::PARQUET_WRONG_PRECISION, filename, schema_element.name, : schema_element.precision, slot_desc->type().precision); : RETURN_IF_ERROR(state->LogOrReturnError(msg)); : > This of the code part checks if there is a precision mismatch between Parqu Sounds good, Thanks for the explanation. -- To view, visit http://gerrit.cloudera.org:8080/11000 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib8c41bfc7c1664bdba5099d3893dc8dbe4304794 Gerrit-Change-Number: 11000 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 01 Aug 2018 16:51:27 +0000 Gerrit-HasComments: Yes
