Tim Armstrong has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/11085 )
Change subject: IMPALA-7317: comment on long lines and whitespace
......................................................................
IMPALA-7317: comment on long lines and whitespace
Add some basic formatting checks that can be implemented
easily by parsing the diff line-by-line. These are applied
to Java, Python, C++, shell and thrift source files with
some exclusions.
Adds a --dryrun option that does not try to post back the
comments to gerrit.
Remove the option to specify a git revision since flake8-diff doesn't
work correctly when run on source that isn't checked out.
Testing:
Added some violations to this code change that will be
fixed before merging. The output is:
{
"comments": {
"bin/jenkins/critique-gerrit-review.py": [
{
"message": "flake8: E501 line too long (107 > 90 characters)",
"range": {
"start_character": 90,
"start_line": 124,
"end_line": 124,
"end_character": 91
}
},
{
"message": "tab used for whitespace",
"line": 125
}
]
}
}
Change-Id: I36bb99560ab09d7753ff93227d1c4972582770f2
Reviewed-on: http://gerrit.cloudera.org:8080/11085
Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Tested-by: Tim Armstrong <tarmstr...@cloudera.com>
---
M bin/jenkins/critique-gerrit-review.py
1 file changed, 91 insertions(+), 5 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved
Tim Armstrong: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I36bb99560ab09d7753ff93227d1c4972582770f2
Gerrit-Change-Number: 11085
Gerrit-PatchSet: 8
Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
