Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10988 )
Change subject: IMPALA-7297: soft memory limit for reservation increases ...................................................................... Patch Set 5: (4 comments) Sorry for the delay, lost track of this one http://gerrit.cloudera.org:8080/#/c/10988/5/be/src/runtime/bufferpool/buffer-pool.h File be/src/runtime/bufferpool/buffer-pool.h: http://gerrit.cloudera.org:8080/#/c/10988/5/be/src/runtime/bufferpool/buffer-pool.h@178 PS5, Line 178: check_soft_mem_limit > nit: mem_limit_mode Done http://gerrit.cloudera.org:8080/#/c/10988/5/be/src/runtime/bufferpool/reservation-tracker.cc File be/src/runtime/bufferpool/reservation-tracker.cc: http://gerrit.cloudera.org:8080/#/c/10988/5/be/src/runtime/bufferpool/reservation-tracker.cc@84 PS5, Line 84: MemLimit::HARD > I'm not too familiar with the ReservationTracker stuff, so maybe this is wr I think either way is equivalent, but mem_limit_mode_ probably makes more intuitive sense. http://gerrit.cloudera.org:8080/#/c/10988/5/be/src/runtime/mem-tracker-types.h File be/src/runtime/mem-tracker-types.h: http://gerrit.cloudera.org:8080/#/c/10988/5/be/src/runtime/mem-tracker-types.h@18 PS5, Line 18: : #ifndef IMPALA_RUNTIME_MEM_TRACKER_TYPES_H : #define IMPALA_RUNTIME_MEM_TRACKER_TYPES_H : > we've moved to '#pragma once' in Kudu for this, no such preference in impal I don't think it's been on our radar. Technically the Google C++ style guide seems to not allow it, but probably it makes sense - I think all our compilers support it. I'll start a discussion on the mailing list and update our style guide on the wiki. https://google.github.io/styleguide/cppguide.html#Windows_Code http://gerrit.cloudera.org:8080/#/c/10988/5/be/src/runtime/mem-tracker.cc File be/src/runtime/mem-tracker.cc: http://gerrit.cloudera.org:8080/#/c/10988/5/be/src/runtime/mem-tracker.cc@41 PS5, Line 41: DEFINE_double > maybe make this hidden if we dont expect users to configure it initially? Done -- To view, visit http://gerrit.cloudera.org:8080/10988 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39dcf2dd870a59c8b8cda4488fe41ce936d715ac Gerrit-Change-Number: 10988 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 01 Aug 2018 18:46:11 +0000 Gerrit-HasComments: Yes
