Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11064 )
Change subject: IMPALA-7362: Add query option to set timezone ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/11064/5/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/11064/5/tests/shell/test_shell_commandline.py@42 PS5, Line 42: def find_query_option(key, string, strip_brackets=True): > Are we sure that we plan to follow this rule in Impala? I keep it as it is We were having a discussion about this on the mailing list. I'm actually in favour of enabling this one although a lot of existing code doesn't follow it just for the sake of consistency -- To view, visit http://gerrit.cloudera.org:8080/11064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73de86eff096e1c581d3b56a0d9330d686f77272 Gerrit-Change-Number: 11064 Gerrit-PatchSet: 5 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 01 Aug 2018 20:46:16 +0000 Gerrit-HasComments: Yes
