Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11110 )
Change subject: IMPALA-7387: Set correct MIME type for JSON webpages ...................................................................... Patch Set 4: Code-Review+2 (2 comments) This looks fine to me. I've asked you to add docs for ?raw and ?json in the header files; my apologies if they exist somewhere and I missed them. http://gerrit.cloudera.org:8080/#/c/11110/4/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/11110/4/be/src/util/webserver.cc@438 PS4, Line 438: bool raw_json = (arguments.find("json") != arguments.end()); Could you update webserver.h's comment for this function with what ?json and ?raw do. I'm actually a little bit unclear about the distinction based on the source here and it doesn't seem documented. http://gerrit.cloudera.org:8080/#/c/11110/4/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/11110/4/tests/webserver/test_web_pages.py@97 PS4, Line 97: assert content_type in requests.get(url).headers['Content-Type'] Should this be "==" rather than "in"? -- To view, visit http://gerrit.cloudera.org:8080/11110 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea Gerrit-Change-Number: 11110 Gerrit-PatchSet: 4 Gerrit-Owner: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Comment-Date: Thu, 02 Aug 2018 15:05:40 +0000 Gerrit-HasComments: Yes
