Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/11106 )
Change subject: IMPALA-7385: Fix test-with-docker errors having to do with time zones. ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11106/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11106/1//COMMIT_MSG@14 PS1, Line 14: /etc/timezone Shouldn't it be /etc/localtime ? http://gerrit.cloudera.org:8080/#/c/11106/1/docker/test-with-docker.py File docker/test-with-docker.py: http://gerrit.cloudera.org:8080/#/c/11106/1/docker/test-with-docker.py@504 PS1, Line 504: localtime_link_target = os.readlink("/etc/localtime") : assert "/usr/share/zoneinfo" in localtime_link_target This might be a little more robust: assert os.path.islink('/etc/localtime') localtime_link_target = os.path.realpath('/etc/localtime') assert localtime_link_target.startswith("/usr/share/zoneinfo/") -- To view, visit http://gerrit.cloudera.org:8080/11106 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9facfd9741806e7dbb868d8d06d9296bf86e52f Gerrit-Change-Number: 11106 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Comment-Date: Thu, 02 Aug 2018 17:39:46 +0000 Gerrit-HasComments: Yes
