Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11087 )
Change subject: IMPALA-7354: planner test resource estimates for more workloads ...................................................................... Patch Set 5: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/11087/5/fe/src/main/java/org/apache/impala/planner/Planner.java File fe/src/main/java/org/apache/impala/planner/Planner.java: http://gerrit.cloudera.org:8080/#/c/11087/5/fe/src/main/java/org/apache/impala/planner/Planner.java@273 PS5, Line 273: printBytes > My thought was that the reservation is a precise number (if the query gets not too strong an opinion on this one. just noted that in the commit message, part of this change was motivated by user perception so wanted to see more about the difference between these too. I'm fine with keeping it this way. -- To view, visit http://gerrit.cloudera.org:8080/11087 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a9f836699200ea87fb03bf36abad0e23949ac26 Gerrit-Change-Number: 11087 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Fri, 03 Aug 2018 22:51:14 +0000 Gerrit-HasComments: Yes