Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10995 )
Change subject: IMPALA-7325: Incorrect SHOW CREATE VIEW with built-in functions ...................................................................... IMPALA-7325: Incorrect SHOW CREATE VIEW with built-in functions In the prior code, the authorization checker for the masked privilege requests skips the check for system database access. As a result, certain commands, such as SHOW CREATE VIEW that references built-in database requires permission to access to the built-in database where accessing built-in database should always be allowed. The patch fixes it by using the authorizePrivilegeRequest() method that does a check on the system database similar to how other authorization checks are performed. Testing: - Added new authorization test - Ran all FE tests Change-Id: Ia164c55fd9459cf5f11eb72561e9cd4ffe1d5367 Reviewed-on: http://gerrit.cloudera.org:8080/10995 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java M fe/src/test/java/org/apache/impala/common/FrontendTestBase.java 3 files changed, 42 insertions(+), 2 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/10995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia164c55fd9459cf5f11eb72561e9cd4ffe1d5367 Gerrit-Change-Number: 10995 Gerrit-PatchSet: 8 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Adam Holley <ahol...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com>
