Bharath Vissapragada has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11110 )
Change subject: IMPALA-7387: Set correct MIME type for JSON webpages ...................................................................... IMPALA-7387: Set correct MIME type for JSON webpages Right now Impala sets "text/plain" as the MIME type for all non-HTML pages. As per RFC-4627[1], JSON's prescribed MIME type is "application/json". Additionally, this commit also sets UTF-8 charset for text/[html/plain] encodings. As per [2] application/json does not require it to be set. Testing: - Inspected HTTP headers manually in the browser. - Added tests. [1] http://www.ietf.org/rfc/rfc4627.txt [2] https://www.iana.org/assignments/media-types/application/json Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea Reviewed-on: http://gerrit.cloudera.org:8080/11110 Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Reviewed-by: Philip Zeyliger <phi...@cloudera.com> --- M be/src/util/webserver.cc M be/src/util/webserver.h M tests/webserver/test_web_pages.py 3 files changed, 38 insertions(+), 5 deletions(-) Approvals: Impala Public Jenkins: Verified Philip Zeyliger: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/11110 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea Gerrit-Change-Number: 11110 Gerrit-PatchSet: 12 Gerrit-Owner: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Anonymous Coward #168 Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com>
