Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10998 )
Change subject: IMPALA-6857: Add Jvm pause/GC Monitor utility and expose JMX metrics ...................................................................... Patch Set 10: (9 comments) Rebased this on top of IMPALA-7387. The earlier PS was dumping the entire JSON string returned by the fe as a single string. That does not work well with the template rendering logic and application/json content-type. So the latest PS parses the JSON returned by the fe and pretty prints it in the web page with the right content-type. Had to make a few minor changes in the webserver class to get this right. Phil, can you take another quick look at this? http://gerrit.cloudera.org:8080/#/c/10998/10/be/src/util/memory-metrics.cc File be/src/util/memory-metrics.cc: http://gerrit.cloudera.org:8080/#/c/10998/10/be/src/util/memory-metrics.cc@161 PS10, Line 161: JvmMemoryMetric* JvmMemoryMetric::CreateAndRegister(MetricGroup* metrics, const string& key, > line too long (92 > 90) Done http://gerrit.cloudera.org:8080/#/c/10998/10/be/src/util/memory-metrics.cc@166 PS10, Line 166: return metrics->RegisterMetric(new JvmMemoryMetric(MetricDefs::Get(key, pool_name_for_key), > line too long (93 > 90) Done http://gerrit.cloudera.org:8080/#/c/10998/10/be/src/util/memory-metrics.cc@184 PS10, Line 184: JvmMemoryMetric::CreateAndRegister(metrics, "jvm.$0.max-usage-bytes", usage.name, MAX); > line too long (91 > 90) Done http://gerrit.cloudera.org:8080/#/c/10998/10/be/src/util/memory-metrics.cc@187 PS10, Line 187: JvmMemoryMetric::CreateAndRegister(metrics, "jvm.$0.committed-usage-bytes", usage.name, > line too long (91 > 90) Done http://gerrit.cloudera.org:8080/#/c/10998/10/be/src/util/memory-metrics.cc@189 PS10, Line 189: JvmMemoryMetric::CreateAndRegister(metrics, "jvm.$0.init-usage-bytes", usage.name, INIT); > line too long (93 > 90) Done http://gerrit.cloudera.org:8080/#/c/10998/10/be/src/util/memory-metrics.cc@192 PS10, Line 192: JvmMemoryMetric::CreateAndRegister(metrics, "jvm.$0.peak-current-usage-bytes", usage.name, > line too long (94 > 90) Done http://gerrit.cloudera.org:8080/#/c/10998/10/be/src/util/memory-metrics.cc@194 PS10, Line 194: JvmMemoryMetric::CreateAndRegister(metrics, "jvm.$0.peak-committed-usage-bytes", usage.name, > line too long (96 > 90) Done http://gerrit.cloudera.org:8080/#/c/10998/10/be/src/util/memory-metrics.cc@196 PS10, Line 196: JvmMemoryMetric::CreateAndRegister(metrics, "jvm.$0.peak-init-usage-bytes", usage.name, > line too long (91 > 90) Done http://gerrit.cloudera.org:8080/#/c/10998/10/tests/custom_cluster/test_pause_monitor.py File tests/custom_cluster/test_pause_monitor.py: http://gerrit.cloudera.org:8080/#/c/10998/10/tests/custom_cluster/test_pause_monitor.py@23 PS10, Line 23: class TestPauseMonitor(CustomClusterTestSuite): > flake8: E302 expected 2 blank lines, found 1 Didn't know about this. Fixed https://lintlyci.github.io/Flake8Rules/rules/E302.html -- To view, visit http://gerrit.cloudera.org:8080/10998 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30d897b7e063846ad6d8f88243e2c04264da0341 Gerrit-Change-Number: 10998 Gerrit-PatchSet: 10 Gerrit-Owner: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Tue, 07 Aug 2018 06:33:33 +0000 Gerrit-HasComments: Yes
