Vuk Ercegovac has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11053 )

Change subject: IMPALA-7203. Support UDFs in LocalCatalog
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11053/3/fe/src/main/java/org/apache/impala/util/FunctionUtils.java
File fe/src/main/java/org/apache/impala/util/FunctionUtils.java:

http://gerrit.cloudera.org:8080/#/c/11053/3/fe/src/main/java/org/apache/impala/util/FunctionUtils.java@84
PS3, Line 84: // TODO(todd): cache these jars based on the mtime and file ID of 
the
            :       // remote JAR? Can we share a cache with the backend?
> that's right, this now runs on the coordinator, and downloads a new copy of
makes sense, so it would only be used by implementations that use direct or 
caching providers.



--
To view, visit http://gerrit.cloudera.org:8080/11053
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6130d07b9c641525382a618a9f8da048c7ae75ed
Gerrit-Change-Number: 11053
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Aug 2018 16:44:50 +0000
Gerrit-HasComments: Yes

Reply via email to