Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11166 )
Change subject: IMPALA-7361: Fix flakiness in test_heterogeneous_proc_mem_limit ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11166/1/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/11166/1/tests/custom_cluster/test_admission_controller.py@504 PS1, Line 504: for impalad in self.cluster.impalads: > I kind of wonder if this should be a helper function, I think we've used th yup, I used it in my query cancellation tests. including this, its used only at 2 places. If this becomes a common occurrence, we can definitely create a helper function -- To view, visit http://gerrit.cloudera.org:8080/11166 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e5c9b0c6a99d7157640c02e6b3c808b4ae9e73c Gerrit-Change-Number: 11166 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 08 Aug 2018 19:09:55 +0000 Gerrit-HasComments: Yes
