Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11191 )
Change subject: IMPALA-7408: add a flag to disable reading fs data from catalogd ...................................................................... Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/11191/1/be/src/common/global-flags.cc File be/src/common/global-flags.cc: http://gerrit.cloudera.org:8080/#/c/11191/1/be/src/common/global-flags.cc@203 PS1, Line 203: "require access to file-system data blocks. Useful for debugging " tab used for whitespace http://gerrit.cloudera.org:8080/#/c/11191/1/be/src/common/global-flags.cc@204 PS1, Line 204: "metadata issues."); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/11191/1/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/11191/1/tests/common/custom_cluster_test_suite.py@186 PS1, Line 186: t flake8: E501 line too long (97 > 90 characters) http://gerrit.cloudera.org:8080/#/c/11191/1/tests/common/custom_cluster_test_suite.py@189 PS1, Line 189: ' flake8: E501 line too long (94 > 90 characters) http://gerrit.cloudera.org:8080/#/c/11191/1/tests/common/custom_cluster_test_suite.py@203 PS1, Line 203: + flake8: W503 line break before binary operator http://gerrit.cloudera.org:8080/#/c/11191/1/tests/custom_cluster/test_disable_catalog_data_ops.py File tests/custom_cluster/test_disable_catalog_data_ops.py: http://gerrit.cloudera.org:8080/#/c/11191/1/tests/custom_cluster/test_disable_catalog_data_ops.py@24 PS1, Line 24: class TestDisableCatalogDataOps(CustomClusterTestSuite): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/11191/1/tests/custom_cluster/test_disable_catalog_data_ops.py@33 PS1, Line 33: ) flake8: E501 line too long (91 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/11191 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15789fb489b285e2a6565025eb17c63cdc726354 Gerrit-Change-Number: 11191 Gerrit-PatchSet: 1 Gerrit-Owner: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Fri, 10 Aug 2018 21:30:47 +0000 Gerrit-HasComments: Yes
