Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11194 )
Change subject: IMPALA-7426: Use Mann-Whitney U to compare benchmarks ...................................................................... Patch Set 1: (14 comments) http://gerrit.cloudera.org:8080/#/c/11194/1/tests/benchmark/report_benchmark_results.py File tests/benchmark/report_benchmark_results.py: http://gerrit.cloudera.org:8080/#/c/11194/1/tests/benchmark/report_benchmark_results.py@121 PS1, Line 121: \ flake8: E502 the backslash is redundant between brackets http://gerrit.cloudera.org:8080/#/c/11194/1/tests/benchmark/report_benchmark_results.py@380 PS1, Line 380: ; flake8: E703 statement ends with a semicolon http://gerrit.cloudera.org:8080/#/c/11194/1/tests/benchmark/report_benchmark_results.py@396 PS1, Line 396: s flake8: F821 undefined name 'save_runtime_diffs' http://gerrit.cloudera.org:8080/#/c/11194/1/tests/benchmark/report_benchmark_results.py@396 PS1, Line 396: r flake8: F821 undefined name 'results' http://gerrit.cloudera.org:8080/#/c/11194/1/tests/benchmark/report_benchmark_results.py@396 PS1, Line 396: r flake8: F821 undefined name 'ref_results' http://gerrit.cloudera.org:8080/#/c/11194/1/tests/benchmark/report_benchmark_results.py@396 PS1, Line 396: s flake8: F821 undefined name 'self' http://gerrit.cloudera.org:8080/#/c/11194/1/tests/benchmark/report_benchmark_results.py@396 PS1, Line 396: s flake8: F821 undefined name 'self' http://gerrit.cloudera.org:8080/#/c/11194/1/tests/benchmark/report_benchmark_results.py@396 PS1, Line 396: s flake8: F821 undefined name 'self' http://gerrit.cloudera.org:8080/#/c/11194/1/tests/benchmark/report_benchmark_results.py@573 PS1, Line 573: a flake8: W503 line break before binary operator http://gerrit.cloudera.org:8080/#/c/11194/1/tests/benchmark/report_benchmark_results.py@1016 PS1, Line 1016: def save_runtime_diffs(results, ref_results, change_significant, zval, tval): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/11194/1/tests/benchmark/report_benchmark_results.py@1036 PS1, Line 1036: ? flake8: E501 line too long (94 > 90 characters) http://gerrit.cloudera.org:8080/#/c/11194/1/tests/util/calculation_util.py File tests/util/calculation_util.py: http://gerrit.cloudera.org:8080/#/c/11194/1/tests/util/calculation_util.py@71 PS1, Line 71: def calculate_mwu(samples, ref_samples): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/11194/1/tests/util/calculation_util.py@75 PS1, Line 75: , flake8: E231 missing whitespace after ',' http://gerrit.cloudera.org:8080/#/c/11194/1/tests/util/calculation_util.py@76 PS1, Line 76: , flake8: E231 missing whitespace after ',' -- To view, visit http://gerrit.cloudera.org:8080/11194 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d6631ebeba1422b832def5cd68537624f672fa0 Gerrit-Change-Number: 11194 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Sat, 11 Aug 2018 18:01:08 +0000 Gerrit-HasComments: Yes
