Hello Tim Armstrong, Todd Lipcon, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11124
to look at the new patch set (#5).
Change subject: IMPALA-7364: Bump RapidJSON version to 1.1.0
......................................................................
IMPALA-7364: Bump RapidJSON version to 1.1.0
There're three kinds of broken APIs to fix:
* Document::AddMember can't accept parameters in const char* types. These
parameters should be wrapped with rapidjson::StringRef().
* Document::GetParseError now returns ParseErrorCode instead of a string.
We should wrap it with GetParseError_En(). The error messages are also
changed. Strings in unit tests should be changed correspondingly.
* rapidjson::FileStream is replaced by rapidjson::FileReadStream
Tests:
* Pass all existing tests
Change-Id: I21353b0d769f81c13f506737e41fbac17655245c
---
M be/src/kudu/util/jsonreader-test.cc
M be/src/kudu/util/jsonreader.cc
M be/src/kudu/util/jsonwriter.cc
M be/src/service/impala-http-handler.cc
M be/src/util/collection-metrics.h
M be/src/util/default-path-handlers.cc
M be/src/util/default-path-handlers.h
M be/src/util/logging-support.cc
M be/src/util/metrics.cc
M be/src/util/metrics.h
M be/src/util/redactor-config-parser-test.cc
M be/src/util/redactor.cc
M be/src/util/thread.cc
M be/src/util/webserver-test.cc
M be/src/util/webserver.cc
M bin/impala-config.sh
16 files changed, 73 insertions(+), 42 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/11124/5
--
To view, visit http://gerrit.cloudera.org:8080/11124
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I21353b0d769f81c13f506737e41fbac17655245c
Gerrit-Change-Number: 11124
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
