Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11195 )
Change subject: IMPALA-5031: Remove some undefined behavior of NULL pointers ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11195/2/be/src/util/ubsan.h File be/src/util/ubsan.h: http://gerrit.cloudera.org:8080/#/c/11195/2/be/src/util/ubsan.h@21 PS2, Line 21: mimicking parts of the standard prone > I'm not sure what that's trying to say. How is this mimicking? Isn't it gua I called it mimicry because the functions have similar names and identical signatures. I'll clarify this, as you suggest below, in my next UBSAN patch. Thanks for pointing it out. -- To view, visit http://gerrit.cloudera.org:8080/11195 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c8a6624918389396789a83b32dbf068b9327f76 Gerrit-Change-Number: 11195 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 13 Aug 2018 21:06:20 +0000 Gerrit-HasComments: Yes
