Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11170 )
Change subject: IMPALA-6481: [DOCS] Documented WIDTH_BUCKET function ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/11170/4/docs/topics/impala_math_functions.xml File docs/topics/impala_math_functions.xml: http://gerrit.cloudera.org:8080/#/c/11170/4/docs/topics/impala_math_functions.xml@1713 PS4, Line 1713: . and less than the base value of the next bucket http://gerrit.cloudera.org:8080/#/c/11170/4/docs/topics/impala_math_functions.xml@1715 PS4, Line 1715: are actually (1 to 3.999...), (4, to 6.999...), (7 to 9.999...). and there's the 0th "underflow bucket" with the range (-infinity to 0.999...), and the num_buckets + 1 "overflow bucket" with the range (10 to infinity) http://gerrit.cloudera.org:8080/#/c/11170/4/docs/topics/impala_math_functions.xml@1735 PS4, Line 1735: The below statement returns a list of accounts whose energy : spending ranges between the minimum and maximum values arguments : passed into the function, $50 and $1000. Actually the below statement returns all of the accounts, not just the ones that have energy spendings between $50 and $1000. Bucket 0 (underflow bucket) will be assigned to the accounts whose energy spendings are < $50. Bucket 11 will be assigned to the accounts whose energy spendings are >= $1000. -- To view, visit http://gerrit.cloudera.org:8080/11170 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife9577a65fe342fde160c7cb5fa666e407d5b093 Gerrit-Change-Number: 11170 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-Comment-Date: Tue, 14 Aug 2018 09:53:39 +0000 Gerrit-HasComments: Yes