Tim Armstrong has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/11205 )
Change subject: IMPALA-7356 (part 1 of ?): admission control stress ...................................................................... IMPALA-7356 (part 1 of ?): admission control stress Add initial support for running the stress test in a mode where it tests that memory-based admission control prevents out-of-memory. A new mode is added that can be enabled by passing --test-admission-control=true to concurrent_select.py In this patch, the stress test's builtin "admission control" is still always enabled, because it is useful in achieving a desired level of memory overcommit. However, mem_limit is not set by the test - it should be set by memory-based admission control - and the pass conditions of the test are tightened up so that OOM is not allowed. Admission control rejection/timeout are separated out from other errors because they are expected when a cluster is under stress. Future patches will likely disable or modify the behaviour of the stress test's admission control when --test-admission-control=true. Two columns are added to the output. Here's a sample when running in the old mode against a minicluster with admission control enabled: Done | Running | Mem Lmt Ex | AC Reject | AC Timeout | Time Out | Cancel | Err | Incorrect | Next Qry Mem Lmt | Tot Qry Mem Lmt | Tracked Mem | RSS Mem 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | | 1 | 10 | 0 | 1 | 0 | 0 | 0 | 0 | 0 | 137 | 3954 | 147 | 452 11 | 20 | 0 | 10 | 0 | 0 | 0 | 0 | 0 | 1521 | 12942 | 203 | 446 15 | 30 | 0 | 14 | 0 | 0 | 0 | 0 | 0 | 130 | 18139 | 4382 | 1911 46 | 35 | 19 | 26 | 0 | 0 | 0 | 0 | 0 | 328 | 18101 | 3266 | 2916 98 | 36 | 47 | 50 | 0 | 0 | 0 | 0 | 0 | 270 | 18177 | 3164 | 3087 Also fixes some minor things: * don't fail at startup if result hash and profile directories already exist. * remove old workarounds for incorrect error messages Testing: Ran local stress tests with --test-admission-control set to true and false. Change-Id: Id31a77f1fe6854a56ce54d1de333793e18087be4 --- M tests/stress/concurrent_select.py 1 file changed, 85 insertions(+), 48 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/11205/5 -- To view, visit http://gerrit.cloudera.org:8080/11205 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id31a77f1fe6854a56ce54d1de333793e18087be4 Gerrit-Change-Number: 11205 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>