Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11039 )
Change subject: IMPALA-7342: Add initial support for user-level permissions ...................................................................... Patch Set 21: (9 comments) looks like an improvement. I found several places where the super-type was used where the child would have sufficed. There may be other places as well. Will make another pass. http://gerrit.cloudera.org:8080/#/c/11039/21/fe/src/main/java/org/apache/impala/analysis/GrantRevokePrivStmt.java File fe/src/main/java/org/apache/impala/analysis/GrantRevokePrivStmt.java: http://gerrit.cloudera.org:8080/#/c/11039/21/fe/src/main/java/org/apache/impala/analysis/GrantRevokePrivStmt.java@93 PS21, Line 93: Role name in these are roles now. if they will be extended to include user, pls add a todo. http://gerrit.cloudera.org:8080/#/c/11039/21/fe/src/main/java/org/apache/impala/catalog/AuthorizationPolicy.java File fe/src/main/java/org/apache/impala/catalog/AuthorizationPolicy.java: http://gerrit.cloudera.org:8080/#/c/11039/21/fe/src/main/java/org/apache/impala/catalog/AuthorizationPolicy.java@208 PS21, Line 208: Principal role = getPrincipal(roleName, TPrincipalType.ROLE); can simplify to just: return roleCache_.get(roleName); http://gerrit.cloudera.org:8080/#/c/11039/21/fe/src/main/java/org/apache/impala/catalog/AuthorizationPolicy.java@234 PS21, Line 234: getPrincipal( can't this just be: return userCache_.get(userName); http://gerrit.cloudera.org:8080/#/c/11039/21/fe/src/main/java/org/apache/impala/catalog/AuthorizationPolicy.java@299 PS21, Line 299: nit: extra ws http://gerrit.cloudera.org:8080/#/c/11039/21/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/11039/21/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2973 PS21, Line 2973: Principal Role http://gerrit.cloudera.org:8080/#/c/11039/21/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3015 PS21, Line 3015: Principal Role http://gerrit.cloudera.org:8080/#/c/11039/21/fe/src/main/java/org/apache/impala/util/SentryProxy.java File fe/src/main/java/org/apache/impala/util/SentryProxy.java: http://gerrit.cloudera.org:8080/#/c/11039/21/fe/src/main/java/org/apache/impala/util/SentryProxy.java@135 PS21, Line 135: Principal Role http://gerrit.cloudera.org:8080/#/c/11039/21/fe/src/main/java/org/apache/impala/util/SentryProxy.java@137 PS21, Line 137: Principal Role http://gerrit.cloudera.org:8080/#/c/11039/21/fe/src/main/java/org/apache/impala/util/SentryProxy.java@238 PS21, Line 238: Principal Role; can be more specific now to match the method. Same with the cases below. -- To view, visit http://gerrit.cloudera.org:8080/11039 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07e0d46d2e50d35bd64ee573b5aa4b779eb9e62f Gerrit-Change-Number: 11039 Gerrit-PatchSet: 21 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Adam Holley <ahol...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Wed, 15 Aug 2018 05:49:20 +0000 Gerrit-HasComments: Yes
