Zoram Thanga has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11234 )

Change subject: IMPALA-7444: Improve logging of opening/closing/expiring 
sessions.
......................................................................


Patch Set 1:

(2 comments)

> Just being paranoid here but I hope this doesn't make the log too
 > verbose.

It's definitely more verbose than before, but I think it's worth it. 
Ordinarily, sessions are opened and stay around for a long time compared to 
individual queries. We would ordinarily see a lot of other messages in the log 
between open and close sessions.

http://gerrit.cloudera.org:8080/#/c/11234/1/be/src/service/impala-hs2-server.cc
File be/src/service/impala-hs2-server.cc:

http://gerrit.cloudera.org:8080/#/c/11234/1/be/src/service/impala-hs2-server.cc@367
PS1, Line 367: Done opening
> Opened
Done


http://gerrit.cloudera.org:8080/#/c/11234/1/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

http://gerrit.cloudera.org:8080/#/c/11234/1/be/src/service/impala-server.cc@1236
PS1, Line 1236: Done closing
> Closed
Done



--
To view, visit http://gerrit.cloudera.org:8080/11234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecf2d3ce707cc36c21da8a2459c2f68cf0b56a4a
Gerrit-Change-Number: 11234
Gerrit-PatchSet: 1
Gerrit-Owner: Zoram Thanga <zo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Reviewer: anujphadke <apha...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Aug 2018 05:24:17 +0000
Gerrit-HasComments: Yes

Reply via email to