Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11160 )

Change subject: IMPALA-7412: width_bucket() function overflows too easily
......................................................................


Patch Set 8: Code-Review+2

(1 comment)

Carrying +2

http://gerrit.cloudera.org:8080/#/c/11160/6/be/src/exprs/math-functions-ir.cc
File be/src/exprs/math-functions-ir.cc:

http://gerrit.cloudera.org:8080/#/c/11160/6/be/src/exprs/math-functions-ir.cc@523
PS6, Line 523: bool
> bool?
yes!



--
To view, visit http://gerrit.cloudera.org:8080/11160
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I728cc05d9aef8d081e6f2da66146f6d7b75dbb57
Gerrit-Change-Number: 11160
Gerrit-PatchSet: 8
Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Aug 2018 19:01:19 +0000
Gerrit-HasComments: Yes

Reply via email to