Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11241 )
Change subject: IMPALA-7449: Fix network throughput calculation of DataStreamSender ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11241/2/be/src/runtime/krpc-data-stream-sender.cc File be/src/runtime/krpc-data-stream-sender.cc: http://gerrit.cloudera.org:8080/#/c/11241/2/be/src/runtime/krpc-data-stream-sender.cc@401 PS2, Line 401: row_batch_size * NANOS_PER_SEC > This will overflow around a few gigabyte row_batch_size - is it possible to Good point. The max of our row batch currently is limited to numeric_limits<int32_t>::max(); (https://github.com/apache/impala/blob/master/be/src/rpc/rpc-mgr.cc#L90) so it should be fine as far as I can tell. It probably warrants a DCHECK. -- To view, visit http://gerrit.cloudera.org:8080/11241 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I344ac76c0a1a49b4da3d37d2c547f3d5051ebe24 Gerrit-Change-Number: 11241 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Comment-Date: Fri, 17 Aug 2018 18:36:41 +0000 Gerrit-HasComments: Yes
