Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11270 )
Change subject: IMPALA-7422: Fix a race in QueryState::StartFInstances() ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11270/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11270/1//COMMIT_MSG@14 PS1, Line 14: cnanot > nit: type Done http://gerrit.cloudera.org:8080/#/c/11270/1/be/src/runtime/query-state.cc File be/src/runtime/query-state.cc: http://gerrit.cloudera.org:8080/#/c/11270/1/be/src/runtime/query-state.cc@403 PS1, Line 403: // Update fragment_map_. Has to happen before the thread is spawned below or > Isn't a race still possible between this thread modifying the map in a subs 'fragment_map_' is supposed to be modified by the thread which calls StartFInstances(). Other threads may not access 'fragment_map_' until all fragment instances have finished preparing (i.e. they are blocked on WaitForPrepare()). At this point, there is at least one fragment instance which hasn't yet been started so no other thread should be accessing fragment_map_. Added some comments in query-state.h. -- To view, visit http://gerrit.cloudera.org:8080/11270 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I35f2a5b0ea5143703850ffc229cec0e4294e6a3e Gerrit-Change-Number: 11270 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 20 Aug 2018 20:39:56 +0000 Gerrit-HasComments: Yes