David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11257 )
Change subject: IMPALA-7399: Emit a junit xml report when trapping errors ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/11257/9/lib/python/impala_py_lib/jenkins/generate_junitxml.py File lib/python/impala_py_lib/jenkins/generate_junitxml.py: http://gerrit.cloudera.org:8080/#/c/11257/9/lib/python/impala_py_lib/jenkins/generate_junitxml.py@164 PS9, Line 164: g_ > Not python2.6-compatible. Use {0} Done. I actually waffled on this a bit. I think that it makes more sense to return the file name after all, and have the caller print (or not) as necessary. But I fixed it there. http://gerrit.cloudera.org:8080/#/c/11257/9/testdata/bin/check-schema-diff.sh File testdata/bin/check-schema-diff.sh: http://gerrit.cloudera.org:8080/#/c/11257/9/testdata/bin/check-schema-diff.sh@30 PS9, Line 30: t, we don't call setup_report_build_error. > just say "we don't call setup_report_build_error". Done -- To view, visit http://gerrit.cloudera.org:8080/11257 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd62045bb43357abc2b89a78afff499149d3c3fc Gerrit-Change-Number: 11257 Gerrit-PatchSet: 10 Gerrit-Owner: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Nithya Janarthanan <njanartha...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Comment-Date: Thu, 23 Aug 2018 00:52:14 +0000 Gerrit-HasComments: Yes
