Hello Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11326
to look at the new patch set (#2).
Change subject: IMPALA-7476: Use context to limit scope of StatestoreSubscriber
......................................................................
IMPALA-7476: Use context to limit scope of StatestoreSubscriber
StatestoreSubscribers are outliving the end of
test_statestore.py, causing continued interaction with
the statestored with a lot of log spew in statestored.INFO
and the main test log.
This change converts StatestoreSubscriber to use a
Python context manager. It updates all the tests to
use this context manager. This ensures that the
StatestoreSubscriber runs kill() at the end of
each test.
There is also a circular reference between
StatestoreSubscriber and KillableThreadedServer that
prevents cleanup. This resolves the circular reference
by nulling out some variables on
KillableThreadedServer::shutdown().
Testing:
- Verified log spew is gone
- StatestoreSubscriber::__del__ is called for 16 out
of 17 tests (exception: test_hung_heartbeat) where
before it was called for none
Change-Id: Ie71fac6095cd94343f68b586238aed410ebbca39
---
M tests/statestore/test_statestore.py
1 file changed, 135 insertions(+), 123 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/11326/2
--
To view, visit http://gerrit.cloudera.org:8080/11326
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie71fac6095cd94343f68b586238aed410ebbca39
Gerrit-Change-Number: 11326
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
