Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11297 )
Change subject: IMPALA-7477: Batch-oriented query set construction ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/11297/5/be/src/service/query-result-set.cc File be/src/service/query-result-set.cc: http://gerrit.cloudera.org:8080/#/c/11297/5/be/src/service/query-result-set.cc@87 PS5, Line 87: /// Add a row of expr values nit: Please update comment http://gerrit.cloudera.org:8080/#/c/11297/5/be/src/service/query-result-set.cc@179 PS5, Line 179: num_rows num_rows - start_idx ? http://gerrit.cloudera.org:8080/#/c/11297/5/be/src/service/query-result-set.cc@285 PS5, Line 285: // Add a row of expr values nit: this comment is also obsolete http://gerrit.cloudera.org:8080/#/c/11297/5/be/src/service/query-result-set.cc@456 PS5, Line 456: DCHECK_EQ(num_col, metadata_.columns.size()); Maybe we could use reserve() on result_set_ here as well. -- To view, visit http://gerrit.cloudera.org:8080/11297 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc87a84c34935d0d5841c7f5528eb802527fa809 Gerrit-Change-Number: 11297 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 28 Aug 2018 14:32:10 +0000 Gerrit-HasComments: Yes
