Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/11352 )
Change subject: IMPALA-7508: Add Impala Python GDB module ...................................................................... Patch Set 1: (10 comments) Thanks for the comments. Uploading PS#2. http://gerrit.cloudera.org:8080/#/c/11352/1/infra/gdb/impala-gdb.py File infra/gdb/impala-gdb.py: http://gerrit.cloudera.org:8080/#/c/11352/1/infra/gdb/impala-gdb.py@1 PS1, Line 1: # > I feel like this file should more properly be added to: Done http://gerrit.cloudera.org:8080/#/c/11352/1/infra/gdb/impala-gdb.py@1 PS1, Line 1: # > That would be fine by me. Done http://gerrit.cloudera.org:8080/#/c/11352/1/infra/gdb/impala-gdb.py@22 PS1, Line 22: import gdb > Please add a README.md in this directory or include usage here. Added a README.md. http://gerrit.cloudera.org:8080/#/c/11352/1/infra/gdb/impala-gdb.py@28 PS1, Line 28: class ImpalaGDB: > I think we usually use new-style classes. Done http://gerrit.cloudera.org:8080/#/c/11352/1/infra/gdb/impala-gdb.py@29 PS1, Line 29: # Walk the threadlist to find fragment instance ids. Assumes IMPALA-6416, so > Use triple " for docstring. I meant this as a comment, not a doc string. Leaving is as is. http://gerrit.cloudera.org:8080/#/c/11352/1/infra/gdb/impala-gdb.py@34 PS1, Line 34: def getFragmentInstances(self): > Python's convention is to use snake_case instead of camelCase. Done http://gerrit.cloudera.org:8080/#/c/11352/1/infra/gdb/impala-gdb.py@40 PS1, Line 40: while f is not None > nit: can be simplified to while f: Done http://gerrit.cloudera.org:8080/#/c/11352/1/infra/gdb/impala-gdb.py@62 PS1, Line 62: class FindFragmentInstances(gdb.Command, ImpalaGDB): : "Find all query fragment instance to thread Id mappings in this impalad." : : def __init__(self): : super(FindFragmentInstances, self).__init__( > multiple-inheritance and inheritance in general seem unnecessary here. Thanks! I wasn't happy with the inheritance either. Made get_fragment_instances() a free function. http://gerrit.cloudera.org:8080/#/c/11352/1/infra/gdb/impala-gdb.py@80 PS1, Line 80: "Find IDs of all queries this impalad is currently executing." > Use triple " for docstring. Done http://gerrit.cloudera.org:8080/#/c/11352/1/infra/gdb/impala-gdb.py@95 PS1, Line 95: qid_hi + ':' + qid_low > nit: usually it's preferable to use string format instead of + Done -- To view, visit http://gerrit.cloudera.org:8080/11352 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I24e7026f2265954ed592d6f62110cf8cb2c2202a Gerrit-Change-Number: 11352 Gerrit-PatchSet: 1 Gerrit-Owner: Zoram Thanga <zo...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Comment-Date: Thu, 30 Aug 2018 22:11:07 +0000 Gerrit-HasComments: Yes
